NVIDIA / NVIDIA/recsys-examples
[FEA] Resolve key-to-index mapping in DynamicEmb row-wise input_dist
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 322
- Forks
- 83
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 8
Description
Is your feature request related to a problem? Please describe.
Right now key-to-slot-index resolution happens later in the DynamicEmb lookup path. If we resolve key-to-index mapping in input_dist, we will be able to reuse torchrec's lookup for dynamic use case.
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context, code examples, or references to existing implementations about the feature request here.
By submitting this issue, you agree to follow our code of conduct and our contributing guidelines.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the DynamicEmb row-wise input_dist path and the later key-to-slot-index resolution, then compare the existing TorchRec lookup path. Done means key-to-index mapping occurs in input_dist and TorchRec's lookup can be reused for the dynamic use case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, pytorch
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100