NVIDIA / NVIDIA/raft

[ENH] Move template arguments of `L1Op`, `L2Op` etc to `operator()` for automatic type inferrence

Open
#1,024 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

0 - Backlog cpp enhancement
Dominant language
Cuda
Stars
1k
Forks
251
Avg merge
1d 8h
Merged PRs (30d)
31

Description

Follows a suggestion by @achirkin who believes this would be less error-prone and would simplify the experience on the caller side.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked suggestion in PR 979 discussion_r1024461911 and inspect the definitions and call sites of L1Op, L2Op, and related operators. The work is complete when their template arguments move to operator() and callers can rely on automatic type inference.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend-api-design
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.