NVIDIA / NVIDIA/open-gpu-kernel-modules
src/common/displayport/src/dp_discovery.cpp:48: pointless test ?
Open
Nobody has claimed this yet.
bug
cosmetic-postponed
- Dominant language
- C
- Stars
- 17.4k
- Forks
- 1.9k
- PR merge metrics
- No merged PRs in 30d
Description
Static analyser cppcheck says:
trunk/src/common/displayport/src/dp_discovery.cpp:48:14: style: Expression is always true because 'else if' condition is opposite to previous condition at line 39. [multiCondition]
Source code is
if (status)
{
...
}
else if (!status)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open src/common/displayport/src/dp_discovery.cpp and inspect the conditional around line 48 alongside the preceding check at line 39. Confirm the condition is redundant, simplify the branch structure, and run cppcheck to verify that the multiCondition warning is gone.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Refactor
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100