NVIDIA / NVIDIA/open-gpu-kernel-modules
trunk/src/nvidia/src/kernel/gpu/ce/arch/pascal/kernel_ce_gp100.c:137: unclear coding ?
Open
Beginner friendly
Nobody has claimed this yet.
bug
- Dominant language
- C
- Stars
- 17.4k
- Forks
- 1.9k
- PR merge metrics
- No merged PRs in 30d
Description
Static analyser cppcheck says:
src/nvidia/src/kernel/gpu/ce/arch/pascal/kernel_ce_gp100.c:137:53: style: Clarify calculation precedence for '&' and '?'. [clarifyCalculation]
Source code is
return (NVBIT(pKCe->publicID) & nvlinkP2PCeMask ? NV_TRUE : NV_FALSE);
Presumably
return (NVBIT(pKCe->publicID) & nvlinkP2PCeMask) ? NV_TRUE : NV_FALSE;
was intended ?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open trunk/src/nvidia/src/kernel/gpu/ce/arch/pascal/kernel_ce_gp100.c at line 137 and review the return expression reported by cppcheck. Confirm the intended precedence of '&' and '?' against the surrounding code, then rerun cppcheck or the relevant checks to verify the warning is resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100