NVIDIA / NVIDIA/nvidia-settings

comment on `NVML_ERROR_FREQ_NOT_SUPPORTED` is wrong

Open
#72 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
345
Forks
92
PR merge metrics
No merged PRs in 30d

Description

When working on upgrading CUDA to 11.4, i found a new NVML error type is added NVML_ERROR_FREQ_NOT_SUPPORTED in here. When I was trying to figure out what does that error type mean, i found the comments in code is not right, since it just copy the comment of NVML_ERROR_INSUFFICIENT_RESOURCES .

    NVML_ERROR_VGPU_ECC_NOT_SUPPORTED = 22,  //!< The requested vgpu operation is not available on target device, becasue ECC is enabled
    NVML_ERROR_INSUFFICIENT_RESOURCES = 23,  //!< Ran out of critical resources, other than memory
    NVML_ERROR_FREQ_NOT_SUPPORTED = 24,  //!< Ran out of critical resources, other than memory
    NVML_ERROR_UNKNOWN = 999                 //!< An internal driver error occurred

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open src/nvml.h around the NVML_ERROR_FREQ_NOT_SUPPORTED entry at the linked line and compare its comment with the surrounding error definitions and the CUDA 11.4 NVML documentation. Done means the frequency-related error has an accurate comment rather than duplicating NVML_ERROR_INSUFFICIENT_RESOURCES.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
api
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.