primary display checkbox toggle

When I apply a configuration of a secondary screen, it automaticly becomes the primary screen. This while the checkbox is checked on the page of the first screen, and not on the page of the second screen.

Workaround without code modification: just uncheck the checkbox and check it again. Then apply the configuration.

Workaround with code modification:

--- ctkdisplayconfig.c	2017-12-19 08:58:34.765653703 +0100
+++ ctkdisplayconfig.c	2017-12-19 08:56:40.638983837 +0100
@@ -8331,7 +8331,7 @@
         }
         if (screen->no_scanout) continue;
 
-		if (screen->primaryDisplay && ctk_object->primary_display_changed) {
+        if (screen->primaryDisplay) {
             ret = NvCtrlSetStringAttribute(screen->ctrl_target,
                                            NV_CTRL_STRING_NVIDIA_XINERAMA_INFO_ORDER,
                                            screen->primaryDisplay->typeIdName);

I havn't researched the code enought to say it won't cause bugs, if anyone has a proper fix please share :-)

Start in ctkdisplayconfig.c around the shown NV_CTRL_STRING_NVIDIA_XINERAMA_INFO_ORDER update and inspect how primaryDisplay and primary_display_changed are set when applying a secondary-screen configuration. Reproduce the checkbox scenario, then verify that applying the configuration leaves the intended screen marked primary without requiring a toggle; no test file is mentioned.