NVIDIA / NVIDIA/nvidia-modprobe

Nvidia Modprobe always creates nvidia-uvm and nvidia-uvm-tools as root:root

Open
#7 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
85
Forks
20
PR merge metrics
No merged PRs in 30d

Description

When attempting to create the nvidia-uvm and nvidia-uvm-tools devices, the devices are always created with root UID and GID.

This method ensures that the creation of nvidia-uvm and nvidia-uvm-tools always gets created with root:root

return mknod_helper(major, base_minor, NV_UVM_DEVICE_NAME, NULL) && mknod_helper(major, base_minor + 1, NV_UVM_TOOLS_DEVICE_NAME, NULL);

By passing NULL, this method doesn't utilize the kernel module parameters that are passed to the nvidia driver.

Passing the params path like is done for the nvidiactl and other devices, the permissions on nvidia-uvm and nvidia-uvm-tools can be set properly according to the documentation:

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in modprobe-utils/nvidia-modprobe-utils.c at the nvidia-uvm and nvidia-uvm-tools creation method, then compare it with the nvidiactl path referenced in the issue. Verify the resulting device ownership and permissions against the NVIDIA driver module-parameter documentation; done means both UVM devices honor those parameters instead of always using root:root.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, linux
Domain
operating-systems
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.