NVIDIA / NVIDIA/nvcf

Cloud Tasks should read registry credential secrets from ESS instead of the inline account response

Open
#889 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
218
Forks
72
Avg merge
1d 12h
Merged PRs (30d)
427

Description

Problem

NVCF API stores registry credential secrets in the External Secret Store (ESS), but it also fetches them back and includes the secret values inline in the internal account details response consumed by Cloud Tasks. Cloud Tasks then reads the inline secret to build image pull secrets.

Sending secrets inline in a service to service response is unnecessary now that the value already lives in ESS. Telemetry secrets already follow the pattern where NVCF populates ESS and the downstream reads directly from ESS.

Desired behavior

  • NVCF API omits the secret value from the account details response and instead includes the registry credential id.
  • Cloud Tasks reads the registry credential secret directly from ESS by id, mirroring the telemetry pattern.
  • Rollout is order independent: if an older NVCF still returns the inline secret and no id, Cloud Tasks uses the inline value.

No database schema change is required.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Cloud Tasks consumer of the internal account details response and compare its credential handling with the telemetry ESS pattern. Trace the NVCF response fields and the ESS lookup by registry credential id. Done means new NVCF and Cloud Tasks versions use ESS without inline secrets, while older inline-secret responses still work and no schema change is introduced.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
backend-api-design, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.