NVIDIA / NVIDIA/nvcf

container-cache: hf.conf still carries temporary debug changes

Open
#551 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
218
Forks
72
Avg merge
1d 12h
Merged PRs (30d)
427

Description

Describe the bug

deploy/helm/container-cache/deploy/files/hf.conf carries five commented-out
directives labelled as temporary debugging, present since the initial public
snapshot:

hf.conf:55   # Temporarily disable rate limiting to isolate 503 cause
hf.conf:56   # limit_req  zone=hf_rps burst=10 nodelay;
hf.conf:57   # limit_conn per_ip 8;
hf.conf:78   # access_by_lua_file /etc/nginx/conf.d/lua/lua-access.lua;
hf.conf:119  # access_by_lua_file /etc/nginx/conf.d/lua/lua-access.lua;
hf.conf:238  # access_by_lua_file /etc/nginx/conf.d/lua/lua-access.lua;

Two concrete consequences:

  • nginx.conf:32 and nginx.conf:33 still allocate limit_req_zone hf_rps:10m
    and limit_conn_zone per_ip:10m. The only directives that referenced those
    zones are the commented-out lines above, so 20m of shared memory is reserved
    for zones nothing uses.
  • All three hf.conf server blocks (huggingface.co,
    cas-server.xethub.hf.co, and ~^(.+\.)?hf\.co$) skip
    lua-access.lua, while ngc.conf:68 and proxy-cache.conf:132 run it.

This is not reported as an access-control hole: lua-access.lua documents itself
as S3 access control with presigned-URL verification, and the hf.co blocks proxy
to HuggingFace and isolate cache entries with $auth_hash instead. The point is
that a change described as temporary has been the committed state for months, so
the intended end state is unclear from the file.

Expected behavior

Either restore the directives, or delete them together with the now unused
hf_rps and per_ip zones and drop the "temporarily" wording. Both paths are
owner decisions, so no Pull Request is attached.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading deploy/helm/container-cache/deploy/files/hf.conf and the referenced nginx.conf, then compare the hf.co server blocks with ngc.conf:68 and proxy-cache.conf:132. The owner must decide whether to restore the commented directives or remove them with the unused zones and temporary wording; done means the chosen configuration is consistent across these files.

Written by the indexing model from the issue text.

Assessment

Tech stack
nginx
Domain
infrastructure
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.