ratelimiter: metrics server failure is swallowed by an empty error branch
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 218
- Forks
- 72
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 427
Description
Describe the bug
setupMetrics in src/invocation-plane-services/ratelimiter/cmd/main.go
discards the http.ListenAndServe error in an empty branch:
err := http.ListenAndServe("0.0.0.0:7776", mux)
if err != nil {
}
If the Prometheus listener cannot bind, the service keeps running with no
metrics and logs nothing. Scrapes fail with connection refused and there is no
signal in the pod logs. The sibling setupPprof and setupOlricStats log the
same failure at error level.
staticcheck flags it as SA9003: empty branch.
Expected behavior
An error-level log line naming the failure, matching the other two servers and
the observability rules in AGENTS.md.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in src/invocation-plane-services/ratelimiter/cmd/main.go at setupMetrics and compare its empty error branch with setupPprof and setupOlricStats. Check AGENTS.md for the observability logging rules, then run staticcheck for the reported SA9003 warning. Done means the metrics listener failure is logged at error level with a message naming the failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 85/100