NVIDIA / NVIDIA/nvcf

nvcf-cli task get includes secret names without opt-in

Open Beginner friendly
#460 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
218
Forks
72
Avg merge
1d 12h
Merged PRs (30d)
427

Description

Describe the bug

nvcf-cli task get defines --include-secrets with a default value of
false, but the client omits the includeSecrets query parameter when that
value is false. The NVCT task controllers interpret an omitted parameter as
includeSecrets=true.

As a result, nvcf-cli task get <task-id> can include secret names in its
response even though the user did not opt in. The API returns secret names,
not secret values.

Steps or code to reproduce bug

  1. Call Client.GetTask(ctx, taskID, false).
  2. Observe that the request URL has no includeSecrets query parameter.
  3. The NVCT controllers apply their defaultValue = "true" setting.
  4. For a task with secrets, the response includes the secret names.

The existing NVCT integration tests also show that an explicit
includeSecrets=false suppresses the names.

Expected behavior

The client should always serialize the caller's choice:

  • includeSecrets=false when --include-secrets is not set
  • includeSecrets=true when --include-secrets is set

Additional context

A client regression test should cover both values so the server default cannot
override the CLI's opt-in behavior again.


By submitting this issue, you agree to follow our
code of conduct and our
contributing guidelines.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at Client.GetTask(ctx, taskID, false) and the nvcf-cli task get handling for --include-secrets. Review the existing NVCT integration tests, then add a client regression test covering both false and true values. Done means the request reflects the caller's choice in both cases and false prevents secret names from appearing.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.