NVIDIA / NVIDIA/nvcf

Root go-lib tests quarantined in CI (core, icms-translate); nvcf-go to fix

Open
#284 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
218
Forks
72
Avg merge
1d 12h
Merged PRs (30d)
427

Description

Problem

The root Bazel matrix row runs with tests_skip: true, so no root tests run in
CI (Go library, nvcf-cli, and the Java example). The blanket skip exists because
two src/libraries/go/lib areas are known to fail in the GitHub Actions
environment:

  • //src/libraries/go/lib/pkg/core/... (core_test goroutine-leak detector)
  • //src/libraries/go/lib/pkg/icms-translate/... (env-flaky)

Change

Root tests are now enabled, with just those two packages quarantined via
.github/bazel-root-test-quarantine.txt. Everything else in the root module
(nvcf-cli, the Java example, and all other go-lib packages) now runs on PRs and
main.

Ask (nvcf-go team)

Fix the two quarantined packages at the test layer (goroutine-leak cleanup and
the environment dependency), then delete their entries from the quarantine file
so full root coverage is restored. Do not change production code to make these
pass.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with .github/bazel-root-test-quarantine.txt and the root Bazel matrix configuration, then run the tests under src/libraries/go/lib/pkg/core/... and src/libraries/go/lib/pkg/icms-translate/... in the GitHub Actions environment. Inspect the existing test failures and make test-layer fixes for goroutine-leak cleanup and the environment dependency. Done means both packages pass, their quarantine entries are removed, and the remaining root tests stay enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, go
Domain
ci-cd, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.