NVIDIA / NVIDIA/nvcf

feat(nvcf-cli): update allowedExtraKubernetesTypes on a registered cluster

Open
#1,877 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
218
Forks
72
Avg merge
1d 12h
Merged PRs (30d)
427

Description

Why

The cluster Helm validation policy is set at cluster registration. By design, the policy name is immutable after registration, but the allowed extra Kubernetes types can be updated. nvcf-cli currently exposes only cluster register (create) and a JWKS update, so there is no CLI path to update a registered cluster's allowedExtraKubernetesTypes.

As part of PR #1867 (CLI-only), passing --validation-policy / --validation-extra-type together with --ignore-existing against an already-registered cluster is now rejected, because that path only refreshes JWKS and would otherwise silently drop the requested policy. This issue tracks adding a real update path so operators can adjust allowed types without deleting and re-registering the cluster.

What changed

Not yet implemented. Proposed: add a CLI command (for example cluster update-validation-policy, or an equivalent update subcommand) that:

  • updates allowedExtraKubernetesTypes only
  • rejects any attempt to change the policy name; the name must match the stored value
  • uses cluster-side group/version/kind/resource (four-part) types, consistent with cluster register

Dependencies

Depends on the control-plane cluster update endpoint that accepts helmValidationPolicy.allowedExtraKubernetesTypes (PUT of the account cluster resource). That endpoint is backend work owned outside this repo and must exist before the CLI command can function end to end.

References

Relates to #880

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the existing cluster register and JWKS update CLI commands, then review the control-plane cluster update endpoint contract. Done means a command updates only allowedExtraKubernetesTypes, rejects policy-name changes, uses four-part cluster-side types, and works once the dependent endpoint exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
api, cli
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.