NVIDIA / NVIDIA/nvcf

Update RateLimiter Service to handle `ownerNcaId`

Open
#1,280 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
218
Forks
72
Avg merge
1d 12h
Merged PRs (30d)
427

Description

Description

RateLimiter Service should use the ownerNcaId from the Invocation Service for rate limiting purposes. It is likely that protos shared by the two services need to be updated for the new field.

Definition of Done

  • Update unit/integration tests

By submitting this issue, you acknowledge that you are an assigned member of the NVCF development team and agree to follow our code of conduct and our contributing guidelines.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the RateLimiter Service and Invocation Service interfaces, then inspect the shared protos to find where ownerNcaId must be represented. Update the rate-limiting flow to use that field and revise the unit and integration tests until they verify the new behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.