NVIDIA / NVIDIA/nvcf

Update `ClientInvokeResponse` with a new field to send EUG's owner nca-id

Open
#1,278 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
218
Forks
72
Avg merge
1d 12h
Merged PRs (30d)
427

Description

Description

Update ClientInvokeResponse in nvcf.proto in cloud-functions with a new field called clientOwnerNcaId. Send both clientNcaId and clientOwnerNcaId to the Invocation Service using the values of the corresponding fields from the key validation / policy evaluation result.

We can avoid this task by just sending the ownerNcaId from the validation/evaluation result in place of the ncaId that we currently do. This will also mean that we can avoid changes to Invocation Service and Rate Limiter Service. However, this can cause confusion down the road if we don't keep the ncaId and ownerNcaId separate in all the places.

Definition of Done

  • Update unit and integration tests

By submitting this issue, you acknowledge that you are an assigned member of the NVCF development team and agree to follow our code of conduct and our contributing guidelines.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with ClientInvokeResponse in nvcf.proto and trace how the key validation or policy evaluation result reaches the Invocation Service. Add the separate clientOwnerNcaId value alongside clientNcaId, then update the unit and integration tests to verify both values are sent correctly.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.