NVIDIA / NVIDIA/nvbench

Compile the list of public API provided by NVBench library

Open
#355 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Cuda
Stars
927
Forks
123
Avg merge
2d 10h
Merged PRs (30d)
2

Description

Regarding #1, we should review the list of symbols we intend to be public, export them (i.e., add __declspec(dllexport) annotation for MSVC) and hide the rest (i.e. add __attribute__((visibility("hidden"))) for GCC/Clang).

Incidentally, doing this review would unblock #323

Originally posted by @oleksandr-pavlyk in https://github.com/NVIDIA/nvbench/issues/354#issuecomment-4398921089

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with issue #1 and inspect the library's existing MSVC and GCC/Clang symbol-visibility setup; this issue names no files or tests. Done means the intended public symbols are reviewed and exported, the remaining symbols are hidden, and the work unblocks issue #323.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend-api-design
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.