NVOS_IS_UNIX is not defined
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 239
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Description
When including nvapi.h in a project that has MSVC warning C4668 enabled, the following is emitted
nvapi\nvapi_lite_common.h(73,7): warning C4668: 'NVOS_IS_UNIX' is not defined as a preprocessor macro, replacing with '0' for '#if/#elif'
While this is minor, it would make for a cleaner compile if this macro could be defined (or if the feature test could checks for the macro being defined ahead of trying to evaluate it)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at nvapi\nvapi_lite_common.h line 73 and inspect the preprocessor condition involving NVOS_IS_UNIX. Verify the change by including nvapi.h in an MSVC project with warning C4668 enabled; done means the undefined-macro warning no longer appears.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100