NVIDIA / NVIDIA/nvapi

Official NVAPI R560 release is broken!!!

Open
#11 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C
Stars
239
Forks
39
PR merge metrics
No merged PRs in 30d

Description

@sujatas-NV @planke-NV @arunimam-NV

nvapi.h includes nvapi_lite_salstart.h which in turn uses a symbol NvAPI_Status which is only defined later in nvapi_lite_common.h (which also includes nvapi_lite_salstart.h before it defines the symbol).

This level of software engineering incompetence with basic C/C++ stuff such as header files, order of including, avoiding cyclic inclusions, and symbols being used before defining is staggering even when it doesn't result in unusable release -- I'd expect it from students learning C in high school class, not from NVIDIA employees even if those are new hires.

You all should be ashamed of yourself for allowing this to be released in such a broken state both here and in R560-developer.zip download from developer.nvidia.com.

Bug ID #4919663.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with nvapi.h, nvapi_lite_salstart.h, and nvapi_lite_common.h, following the include chain and the declaration of NvAPI_Status. Reproduce the R560 header failure with a minimal C or C++ compilation test. Done means the released headers compile without using NvAPI_Status before its definition or creating an unusable include cycle.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cpp
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.