NVIDIA / NVIDIA/daqiri

Use of '#' as first character in commit title can be construed as a comment in some environments

Open Beginner friendly
#314 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
36
Forks
11
Avg merge
3d 4h
Merged PRs (30d)
25

Description

Regarding the contributing requirement:

https://github.com/NVIDIA/daqiri/blob/89e8ecbb33761795a5884ab57fac8fe2037ead3d/CONTRIBUTING.md?plain=1#L48

I have noticed that certain environments, such as editing a commit in a text editor with 'git commit' or 'git commit --amend' instead of using the -m option to add the commit directly on the command line, result in the hash sign '#' being treated as a comment.

Perhaps consider an alternative mechanism to identify the issue number?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with CONTRIBUTING.md at the referenced section around line 48 and review how issue numbers are required in commit titles. Update the guidance so the issue identifier cannot be mistaken for a comment when editing commits in a text editor; done means the requirement is unambiguous for both command-line and editor-based commits.

Written by the indexing model from the issue text.

Assessment

Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
75/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.