NVIDIA / NVIDIA/cuvs

[FEA] Expose `trustworthiness_score` on more `double` inputs

Open
#775 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

cuvs::stats::trustworthiness_score supports only float input arrays (header). It would be nice (if low priority) if it could also support double inputs for use in cuml. As is, we need to copy and cast double arrays to float arrays (increasing memory usage) to call trustworthiness_score.

I think this should be pretty straightforward - the implementation is already templated on math_t, it's just not exposed through the header.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with cpp/src/stats/trustworthiness_score.cu and the public header section linked in the issue, then compare it with the templated implementation in cpp/src/stats/detail/trustworthiness_score.cuh. Confirm how the public API currently restricts input types. Done means double input arrays can call trustworthiness_score directly without copying and casting to float.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.