NVIDIA / NVIDIA/cuvs

[BUG] Enable "SVE" opt level for Faiss on Grace CPU

Open
#755 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

Describe the bug
The FAISS_OPT_LEVEL isn't set to "sve" on Grace CPU which has "SVE" CPU feature. However, the "avx2" opt level is set for AVX2 enabled platform.

https://github.com/rapidsai/cuvs/blob/bd6d4a9934ad7f3f3cf2e2c6446abdbdf10ffba0/cpp/cmake/thirdparty/get_faiss.cmake#L44-L47

Expected behavior
Enable SVE optimizations when the CPU supports it.

Additional context
According to the options listed here CMakeLists.txt#60 FAISS does support SVE.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with cpp/cmake/thirdparty/get_faiss.cmake at lines 44-47, then compare the supported FAISS options in the upstream CMakeLists.txt at line 60. Verify that FAISS_OPT_LEVEL is set to "sve" for Grace CPUs with SVE support, and confirm the resulting configuration or build succeeds.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.