NVIDIA / NVIDIA/cuvs

[ENH] Refactoring of dynamic batching implementation details

Open
#511 0 comments 0 reactions 1 assignee View on GitHub

@achirkin is already working on this.

Since Dec 4, 2024.

bug
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

Consider refactoring cpp/src/neighbors/detail/dynamic_batching.cuh to have more separation between the batch runner class and the queue type by encapsulating commit and wait logic in the queue.

Originally posted by @tfeher in https://github.com/rapidsai/cuvs/pull/261#discussion_r1864894880 https://github.com/rapidsai/cuvs/pull/261#discussion_r1864894880 https://github.com/rapidsai/cuvs/pull/261#discussion_r1864901157

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.