NVIDIA / NVIDIA/cuvs

[BUG] Reuse C API parameter structs in C++

Open
#487 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

We should use the C parameters structs in C++, e.g. using cuvsCagraExtendParams instead of cuvs::neighbors::cagra::extend_params, since having parallel objects like this increases the maintenance burden. An example where this is already done:

https://github.com/rapidsai/cuvs/blob/72154b0b806c106300b52870f6113fdda3f87f0b/cpp/include/cuvs/distance/distance.hpp#L27

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the existing example in cpp/include/cuvs/distance/distance.hpp, then locate the parallel C++ and C parameter structs, including cuvsCagraExtendParams and cuvs::neighbors::cagra::extend_params. The work is done when the C++ API reuses the C parameter structs consistently and the project’s existing checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
c, cpp
Domain
api
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.