[BUG] Unify constness usage for bitset filters of ANN
Open
Nobody has claimed this yet.
bug
- Dominant language
- Cuda
- Stars
- 854
- Forks
- 236
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 62
Description
To unify the use of bitset filters for different ANN, the filter should use constness on its data type.
Currently only Bruteforce is using const filter: https://github.com/rapidsai/cuvs/blob/branch-24.12/cpp/src/neighbors/detail/knn_brute_force.cuh#L738C54-L738C67
The other indexes don't use const filter.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the cited filter usage in cpp/src/neighbors/detail/knn_brute_force.cuh, then inspect the corresponding bitset filter types and usages in the other ANN indexes. The work is done when the ANN filters use consistent constness, with the existing ANN tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100