NVIDIA / NVIDIA/cuvs

[BUG] Distances are not properly tested for ANN indexes

Open
#330 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

Currently the tests for ANN indexes are not checking that the distances computed are correct.
https://github.com/rapidsai/cuvs/blob/branch-24.10/cpp/test/neighbors/ann_utils.cuh#L130-133

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at cpp/test/neighbors/ann_utils.cuh lines 130-133 and inspect how distances are currently checked in the ANN index tests. Add coverage that validates the computed distances, then run the affected ANN tests and confirm incorrect distances are detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
search, testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.