NVIDIA / NVIDIA/cuvs

[FEA] Rename cagraCompressionParams to cuvsPqParams

Open
#2,576 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

Reference discussion: https://github.com/NVIDIA/cuvs/pull/1810#discussion_r3939713322
This might be an ABI breaking change!
We should also consider combining it with cuvsProductQuantizerParams. We probably dont need two different C structs for PQ params.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the reference discussion in PR #1810 and inspect the declarations and uses of cagraCompressionParams and cuvsProductQuantizerParams. Resolve whether this is only a rename or should combine the two C structs, including the ABI impact; done means the agreed public API is consistent.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Active
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.