NVIDIA / NVIDIA/cuvs

[FEA][C API] Migrate merge() Dataset API to have users pass in concatenated dataset + integer offset.

Open
#2,401 0 comments 0 reactions 1 assignee View on GitHub

@HowardHuang1 is already working on this.

Since Aug 21, 2026.

feature request
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

Migrate merge() contract the same way we did with extend().

Users should be responsible with concatenating the 2 datasets into 1 merged dataset and provide that single merged dataset + integer offset. Merge() should then merge graph only.

Remove merged_storage struct.

Think about how to pre-calculate merged storage size after bitset filter:
https://github.com/NVIDIA/cuvs/pull/1846#discussion_r3639389310

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.