[FEA][Language Wrappers] Remove dataset views from language wrappers
Nobody has claimed this yet.
- Dominant language
- Cuda
- Stars
- 854
- Forks
- 236
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 62
Description
https://github.com/NVIDIA/cuvs/pull/1846#discussion_r3688007585
https://github.com/NVIDIA/cuvs/pull/1846#discussion_r3678355568
@tarang-jain mentioned in slack:
We should remove the explicit "view" type above and add a member to the dataset_t to designate whether it's owning (this isn't unlike Python ndarray)
We should make sure the c++ impl of the C apis is properly creating a view when needed (if the dastaset_t passed in is owning)
Follow up with @aamijar, @tarang-jain, and @divyegala
Current status is none of the language wrappers have had views removed yet except python (confirm with @tarang-jain). For other language wrappers, we need to evaluate each on a case by case basis.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked pull request discussions and inspect the existing language-wrapper implementations, noting that Python has already removed views while the other wrappers have not. Follow up with @aamijar, @tarang-jain, and @divyegala to determine the required behavior for each wrapper; done means evaluating and updating the applicable wrappers consistently with the C++ C-API implementation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- api, backend-api-design
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100