[FEA] KMeans - Within Iteration Inertia Computation Should Account for Sample Weights
Open
Nobody has claimed this yet.
feature request
- Dominant language
- Cuda
- Stars
- 854
- Forks
- 236
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 62
Description
Final inertia computation is weighted for both kmeans and batched kmeans (#1886), but the within iteration computation (to check for convergence with inertia_check) seems to be not weighted.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by tracing the KMeans and batched KMeans convergence path used by inertia_check, then compare its within-iteration inertia calculation with the weighted final inertia added in #1886. Done means convergence checks account for sample weights and coverage exists for weighted KMeans cases.
Written by the indexing model from the issue text.
Assessment
- Domain
- machine-learning
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100