NVIDIA / NVIDIA/cuvs

[SBIN] Ensure SOVERSION is always enabled in cuvs_c

Open
#1,744 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

This task is to verify and enforce that the Shared Object Versioning (SOVERSION) is consistently enabled no matter the mode of building the cuvs_c shared library. Follow-up requires making sure that any conda/pip wheels related changes are done. The SOVERSION needs to be consistent across the board, but we currently only do that for our early standalone PID releases.

For wheel, with no symlinks, we will use only the ABI major version file

Copied from https://docs.google.com/document/d/13fxnoZQIvJPKDwz-21fXMrux6HtJG7KW5cHafrmJtAo/edit?usp=sharing

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the cuvs_c shared library is built in each mode, then inspect the conda and pip wheel packaging paths. Done means SOVERSION is enabled consistently and wheels without symlinks use only the ABI major version file.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
build-system
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.