NVIDIA / NVIDIA/cuvs

Missing Input Instantiations in IVF-PQ tests

Open Beginner friendly
#1,709 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

Several test case generators are defined in cpp/tests/neighbors/ann_ivf_pq.cuh but are never used in any of the test instantiation files. Therefore it looks like these test scenarios are never exercised in CI.

  • special_cases()
  • var_n_probes()
  • big_dims_small_lut()
Current Test Instantiations

Looking at the test files in cpp/tests/neighbors/ann_ivf_pq/:

test_float_int64_t.cu:
INSTANTIATE(f32_f32_i64,
defaults() + small_dims() + big_dims_moderate_lut() + enum_variety_l2() +
enum_variety_l2sqrt() + enum_variety_ip() + enum_variety_cosine());

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the test case generators in cpp/tests/neighbors/ann_ivf_pq.cuh and compare them with the instantiations in cpp/tests/neighbors/ann_ivf_pq/. Check the existing test files, including test_float_int64_t.cu, then run the IVF-PQ tests. Done means special_cases(), var_n_probes(), and big_dims_small_lut() are instantiated and exercised in CI.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
67/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.