NVIDIA / NVIDIA/cuvs

[FEA] ANN bench improvements

Open
#160 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

During porting the ANN benchmarks from RAFT (#130), a list of potential improvements was created:

  • clang-tidy: cleanup naming conventions
  • cleanup/unify logging (including CPU-only builds)
  • fix/unify create_algo + create_search_param syntax
  • actualize cuda_stub.hpp for cpu-only builds
  • make sure there's no direct cuda dependencies in benchmark.hpp
  • add the memory interconnect info to benchmark context
  • add command line string which used for running the benchmarking to the benchmark context
  • add more information about CPU cores and RAM to the benchmark context
  • etc...

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review the remaining unchecked items in benchmark.hpp and cuda_stub.hpp, then trace the create_algo and create_search_param call sites. Check the CPU-only build and benchmark logging paths first. Done means the selected cleanup items are implemented and the relevant benchmark builds work without direct CUDA dependencies where noted.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
performance, testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.