[BUG] CAGRA IP Distance returning invalid neighbors
@tarang-jain is already working on this.
Since May 24, 2024.
- Dominant language
- Cuda
- Stars
- 854
- Forks
- 236
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 62
Description
Zilliz changed their CAGRA testing for IP distance to generate random numbers with negatives and they found some of the neighbors being returned are -1.
What's also weird about their test results is that they were using nn-descent and not getting an exception (since nn-descent doesn't yet support IP).
While beginning triage this issue in Python, I realized that the IP distance was never exposed in the Python layer. We should fix this and also add explicit pytests to verify 1) correct neighbors are returned when negatives are in the input vectors, and 2) the algorithm fails gracefully when IP distance is used with nn-descent as the build algo.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.