NVIDIA / NVIDIA/cuvs

[BUG] Copyright checker

Open
#137 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

The copyright checker in pre-commit didn't seem to catch a copyright problem in a newly checked in file. This should have been fixed by the pre-commit hooks, but should also have been spotted by the CI style checker.

Upon further inspection, I don't see the copyright checker script in cuVS at all. We should 1) verify why it's not in the code, 2) add it if it should in fact be included, and 3) find out why the pre-commit hooks aren't firing properly for copyright issues.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the cuVS repository for the copyright checker, pre-commit hooks, and CI style checker mentioned in the issue. Verify whether the checker is present, determine why the hooks and CI do not catch copyright problems, and consider the work done when the expected checking behavior is restored and verified.

Written by the indexing model from the issue text.

Assessment

Domain
build-system, ci-cd, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.