NVIDIA / NVIDIA/cuvs

[FEA] Remove using `cuvs::distance::detail` functions from fusedL2KNN/ bfknn code

Open
#126 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

We are currently using private functions from cuvs::distance::detail for the fusedL2KNN code inside of the brute_force knn api - which is a bit of a hack.

We should find a way to share internal functions, without either exposing these functions to the public api or having to include the detail namespace of unrelated code.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the fusedL2KNN code inside the brute_force knn API and identify its uses of cuvs::distance::detail functions. First determine how those internal functions are currently shared, then define a sharing approach that avoids exposing them publicly or including an unrelated detail namespace. Done means the dependency is removed while the existing fusedL2KNN and brute-force KNN behavior remains intact.

Written by the indexing model from the issue text.

Assessment

Domain
search
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.