NVIDIA / NVIDIA/cuvs

[TECH DEBT] Separate interfaces from source file implementations for remaining headers in `cuvs/include`

Open
#123 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

While doing the migration from RAFT, I found there are still several header files in cuvs/include which define structs and/or classes and they include templates and implementations. We need to separate the interface from the implementations and make sure these are all instantiated for the set of types we plan to use.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inventorying the remaining headers under cuvs/include that define structs or classes and inspect how their templates and implementations are organized. Identify the planned type set and existing instantiation patterns; done means the interfaces and implementations are separated for all applicable headers and the required types are instantiated.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.