[TECH DEBT] Remove all occurrences of `using namespace` for non-cuvs namespaces from header files
Nobody has claimed this yet.
- Dominant language
- Cuda
- Stars
- 854
- Forks
- 236
- Avg merge
- 3d 3h
- Merged PRs (30d)
- 62
Description
This can often ease development times, but it creates a situation where any collisions in functions or object names can create very challenging, if not impossible to debug situations. While this is okay for source files, we should not be doing it in headers because these additional namespaces pollute all other headers that get included.
I noticed this being done throughout the codebase while migrating code from RAFT to cuVS. Unfortunately, we don't have enough time to clean these all up now, but we should make sure we scrape through and clean them up.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the repository's header files for using namespace declarations, then distinguish cuVS namespaces from all others. Done means non-cuVS namespace imports have been removed from headers; review the resulting matches and build or test the affected library components if available.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100