NVIDIA / NVIDIA/cuvs

[FEA] Rename `knn_merge_parts`

Open
#1,157 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature request
Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

This name was once meant for lower-level use in RAFT, but has since been moved to cuVS and now that it's exposed through public APIs, the name really no longer matches the current naming schemes.

We should find a better name for it, and potentially even remove the knn designator- this is really a k-selection merge, so perhaps we should expose it with the k-selection APIs.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the public knn_merge_parts API and its callers in cuVS, then review the k-selection APIs to understand where this operation belongs. Done means agreeing on a replacement name or API location and updating the exposed interface and its references consistently.

Written by the indexing model from the issue text.

Assessment

Domain
api, search
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.