NVIDIA / NVIDIA/cuvs

[Improvement] [Java] Fetch default parameter values from C layer

Open
#1,036 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Cuda
Stars
854
Forks
236
Avg merge
3d 3h
Merged PRs (30d)
62

Description

Currently, we set the default parameter values statically in classes like for example CagraIndexParams

Default values, such as the above, were initially found out by looking here

What could happen instead is that values set during this initialization can be fetched from the C layer via the Java Panama API. With this improvement, there will be a single source of default values (only in the C layer).

I am assigning to myself and will raise a PR as soon as I can.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with java/cuvs-java/src/main/java/com/nvidia/cuvs/CagraIndexParams.java and the corresponding defaults in cpp/src/neighbors/cagra_c.cpp. Trace how initialization currently sets these values, then inspect the Java Panama API path for fetching them from the C layer. Done means the defaults have a single source in the C layer rather than being duplicated in Java.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, java
Domain
backend-api-design
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.