NVIDIA / NVIDIA/cutlass

EpilogueDirectStore warp decomposition uses WarpShape::kN where WarpCount is meant

Open Beginner friendly
#3,496 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

CUTLASS C++
Dominant language
C++
Stars
10.5k
Forks
2.1k
Avg merge
3d 11h
Merged PRs (30d)
7

Description

Description

EpilogueDirectStore's constructor computes the warp decomposition as:

int warp_id_mn = warp_idx % (WarpCount::kM * WarpShape::kN);

(include/cutlass/epilogue/threadblock/epilogue_direct_store.h line 171)

The second factor is a typo: it mixes the warp shape's WarpShape::kN into what should be the warp count. EpilogueBase does this correctly (include/cutlass/epilogue/threadblock/epilogue_base.h lines 219-220):

int warp_mn = warp_idx % (WarpCount::kM * WarpCount::kN);

When WarpCount::kN > WarpShape::kN the modulo truncates warp_idx early and two different warps receive the same (warp_m, warp_n) coordinates. For all currently instantiated direct-store configs WarpCount::kN <= WarpShape::kN, so nothing is observably wrong today; the defect surfaces only for shapes where Shape::kN > WarpShape::kN^2.

Suggested fix

Use warp_idx % WarpCount::kCount (or % (WarpCount::kM * WarpCount::kN) to mirror EpilogueBase).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at include/cutlass/epilogue/threadblock/epilogue_direct_store.h line 171 and compare the warp decomposition with include/cutlass/epilogue/threadblock/epilogue_base.h lines 219-220. Update the decomposition to use the warp count, then verify that the direct-store calculation assigns distinct coordinates for the described warp-count configurations.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.