[QST] some confusion about layout
Open
Nobody has claimed this yet.
? - Needs Triage
inactive-30d
inactive-90d
question
- Dominant language
- C++
- Stars
- 10.5k
- Forks
- 2.1k
- Avg merge
- 3d 11h
- Merged PRs (30d)
- 7
Description
What is your question?
#include <cuda.h>
#include <stdlib.h>
#include <thrust/host_vector.h>
#include <thrust/device_vector.h>
#include <cute/tensor.hpp>
#define PRINT(name, content) \
print(name); \
print(" : "); \
print(content); \
print("\n");
using namespace cute;
template <typename T, typename G2SCopy, typename SmemLayout, int M, int N>
__global__ void copy_global_shm_register(const T *Aptr)
{
int idx = threadIdx.x;
extern __shared__ T shm_data[];
T *Ashm = shm_data;
auto gA = make_tensor(make_gmem_ptr(Aptr), make_shape(Int<M>{}, Int<N>{}), make_stride(Int<N>{}, Int<1>{}));
auto sA = make_tensor(make_smem_ptr(Ashm), SmemLayout{});
G2SCopy g2s_tiled_copy;
auto g2s_thr_copy = g2s_tiled_copy.get_thread_slice(idx);
auto tAgA = g2s_thr_copy.partition_S(gA);
auto tAsA = g2s_thr_copy.partition_D(sA);
cute::copy(g2s_tiled_copy, tAgA((_,_),_,_), tAsA((_,_),_,_));
__syncthreads();
if (idx == 0) {
PRINT("gA.shape()", gA.shape());
PRINT("gA.stride()", gA.stride());
// tAgA.shape() : ((_8,_1),_4,_2)
PRINT("tAgA.shape()", tAgA.shape());
PRINT("tAsA.shape()", tAsA.shape());
}
}
int main()
{
using T = cute::half_t;
constexpr int M = 128;
constexpr int N = 64;
using g2s_copy_op = SM80_CP_ASYNC_CACHEGLOBAL<cute::uint128_t>;
using g2s_copy_traits = Copy_Traits<g2s_copy_op>;
using g2s_copy_atom = Copy_Atom<g2s_copy_traits, T>;
using G2SCopy =
decltype(make_tiled_copy(g2s_copy_atom{},
make_layout(make_shape(Int<32>{}, Int<4>{}),
make_stride(Int<4>{}, Int<1>{})),
make_layout(make_shape(Int<1>{}, Int<8>{}), make_stride(Int<8>{}, Int<1>{}))));
using SmemLayoutAtom = decltype(composition(
Swizzle<3, 3, 3>{},
make_layout(make_shape(Int<8>{}, Int<32>{}),
make_stride(Int<32>{}, Int<1>{}))));
using SmemLayout = decltype(tile_to_shape(SmemLayoutAtom{},
make_shape(Int<M>{}, Int<N>{})));
static constexpr int shm_size = cute::cosize(SmemLayout{}) * sizeof(T);
thrust::host_vector<T> h_A(M*N);
for (int i = 0; i < M * N; ++i) {
h_A[i] = i;
}
thrust::device_vector<T> d_A = h_A;
auto Aptr = thrust::raw_pointer_cast(d_A.data());
dim3 block(32*4);
copy_global_shm_register<T, G2SCopy, SmemLayout, M, N><<<1, block, shm_size>>>(Aptr);
}
The code prints
gA.shape() : (_128,_64)
gA.stride() : (_64,_1)
tAgA.shape() : ((_8,_1),_4,_2)
tAsA.shape() : ((_8,_1),_4,_2)
but I think it should be
gA.shape() : (_128,_64)
gA.stride() : (_64,_1)
tAgA.shape() : ((_1,_8),_4,_2)
tAsA.shape() : ((_1,_8),_4,_2)
When I want to print the second element of thread 0, I should use ?printf("%f\n", (float)(tAgA((2,0),0,0))); or printf("%f\n", (float)(tAgA((2,0),0,0)));
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the provided CUTLASS CUDA example and inspect the make_tiled_copy, get_thread_slice, partition_S, and partition_D calls used in the issue. Trace how the resulting tensor layouts map coordinates to threads and elements, then clarify the reported shapes and indexing in the issue or relevant documentation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- backend, performance
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100