[BUG] get_combined_model() for dask knn returns None
Open
Nobody has claimed this yet.
? - Needs Triage
bug
inactive-30d
inactive-90d
- Dominant language
- Python
- Stars
- 5.3k
- Forks
- 680
- Avg merge
- 1d 13h
- Merged PRs (30d)
- 99
Description
get_combined_model() for dask knn returns None
This function works for dask rf, but not knn.
e.g. this little snippet returns None after model was fitted fine:
from cuml.dask.neighbors import KNeighborsRegressor as KNeighborsDaskRegressor
from cuml.dask.neighbors import KNeighborsClassifier as KNeighborsDaskClassifier
if isinstance(model, (KNeighborsDaskRegressor, KNeighborsDaskClassifier)):
model = model.get_combined_model()
Using rapids 21.08, might be fixed in later versions?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the provided snippet with KNeighborsDaskRegressor and KNeighborsDaskClassifier, using the reported RAPIDS 21.08 context. Compare get_combined_model() behavior with dask random forest and verify that the fitted dask KNN models return a combined model instead of None.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100