NVIDIA / NVIDIA/cudf

[FEA] rolling_window() does not support struct_view for most operations

Open
#7,188 3 comments 0 reactions 0 assignees View on GitHub
feature request libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

It appears that all the `*rolling_window()` functions do not currently support any aggregations on `struct_view` columns. There is no case in [`is_rolling_supported()`](https://github.com/rapidsai/cudf/blob/6c116e382f8fa85d9207babbcc425a18684f06b3/cpp/src/rolling/rolling_detail.hpp#L69) that handles `struct_view`.

In the ideal case, we should support `COUNT_VALID`, `COUNT_ALL`, `ROW_NUMBER`, `LEAD`, `LAG`, and (soon) `COLLECT` on `struct_view`.

(`COLLECT` support should be added when #7133 is addressed.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.