NVIDIA / NVIDIA/cudf

unify env var/default resolution into shared primitives

Open
#23,743 0 comments 0 reactions 1 assignee Claimed by @Matt711 View on GitHub
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

Part of #23740.

`StreamingOptions`'s `_opt()` and `StreamingExecutor`'s `_make_default_factory()` are
independently written, near-identical implementations of "explicit value, then env
var(s), then default". An inline block in `ConfigOptions.from_polars_engine` and
`MemoryResourceConfig()`'s own construction are two more independent copies of "explicit
value, then build a nested object if enabled, then a fallback", for the memory resource
config specifically. Replace both groups with one shared function each, used everywhere a
field of that shape is declared, regardless of which dataclass declares it.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.