NVIDIA / NVIDIA/cudf

Deduplicate where we set the default kvikio thread count

Open
#23,678 0 comments 0 reactions 0 assignees View on GitHub
cudf-polars improvement
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

I think this looks good. As noted, I have a worry that we're replicating default-setting in more than one place. But I think that is probably best done as followup.

What I kind of think should happen is that (somehow) all the options should be resolved before we're making the `XXXEngine`. Or else, constructing the options objects should apply all defaults everywhere.

_Originally posted by @wence- in https://github.com/NVIDIA/cudf/pull/23634#pullrequestreview-4930124511_

Contributor guide

Open the contributing guide

Research direction

The issue concerns duplicated default-setting for the kvikio thread count before constructing the XXXEngine. Start by tracing where those options and defaults are resolved; done means the default is applied consistently from one clear location. No files or tests are named, so repository exploration is required.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.