NVIDIA / NVIDIA/cudf

[FEA] Rename PascalCase types introduced by the rapidsmpf migration to snake_case

Open
#22,769 0 comments 0 reactions 0 assignees View on GitHub
feature request libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

**Is your feature request related to a problem? Please describe.**
#22747 migrates rapidsmpf code into libcudf (the new `libcudf_streaming` library). Some of the migrated types came over with `PascalCase` names that do not follow libcudf's naming convention.

**Describe the solution you'd like**
Per the Developer Guide (https://github.com/rapidsai/cudf/blob/HEAD/cpp/doxygen/developer_guide/DEVELOPER_GUIDE.md#code-and-documentation-style-and-formatting): "libcudf code uses snake_case for all
names except in a few cases: template parameters, unit tests and test case names may use Pascal case." Classes are not an exception.

Rename, e.g. `HashScheme` and `BloomFilter` (and audit the rest of the migrated `libcudf_streaming` code for other PascalCase classes/functions/enums) to `hash_scheme` and `bloom_filter` so the new library matches libcudf conventions.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.