NVIDIA / NVIDIA/cudf

[FEA] Merge duplicate `BinaryOps` and `UnaryOps` into Operator Library

Open
#22,742 0 comments 1 reaction 0 assignees View on GitHub
feature request libcudf
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

**Is your feature request related to a problem? Please describe.**
CUDF has duplicate binary operators and unary operators that could be merged into a single operator library.
A new operator library was introduced in https://github.com/rapidsai/cudf/pull/22514 to address this concern.

Some of the row-operators that can be merged are:

- MathOps (https://github.com/rapidsai/cudf/blob/076b578f4dfc014b51ccbbb0c12cb084493319b0/cpp/src/unary/math_ops.cu)
- CastOps (https://github.com/rapidsai/cudf/blob/076b578f4dfc014b51ccbbb0c12cb084493319b0/cpp/src/unary/cast_ops.cu)
- BinaryOps (https://github.com/rapidsai/cudf/blob/076b578f4dfc014b51ccbbb0c12cb084493319b0/cpp/src/binaryop/compiled/operation.cuh)

**Describe the solution you'd like**
Merge the duplicated operators into the CUDF operator library, thus giving a single source of truth, which will prevent divergence of implementations as their operator support grows and evolves.

**Describe alternatives you've considered**
N/A

**Additional context**
N/A

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.