[FEA] Compile libcudf with `-Wsign-conversion`
Open
feature request
libcudf
- Dominant language
- C++
- Stars
- 9.8k
- Forks
- 1.1k
- Avg merge
- 3d 6m
- Merged PRs (30d)
- 278
Description
**Is your feature request related to a problem? Please describe.**
#21292 is another example of integer overflow lurking in libcudf due to a combination of:
- implicit sign conversion
- usual integer promotion rules
**Describe the solution you'd like**
It would be nice if we could just flat-out ban integer conversions, but unfortunately, in C++, that ship sailed before I was born.
However, we could at least make people stop and think when a `cudf::size_type` value is being passed to an allocation (or similar) function that accepts an unsigned type by adding `-Wsign-conversion` to the compile flags.
Contributor guide
Assessment
This issue has not been assessed yet.