NVIDIA / NVIDIA/cudf

[FEA] Enable mypy disallow_any_* checks in cudf/core/column

Open
#20,254 1 comment 0 reactions 0 assignees View on GitHub
feature request Python
Dominant language
C++
Stars
9.8k
Forks
1.1k
Avg merge
3d 6m
Merged PRs (30d)
278

Description

As we're adding more type stubs to cuDF classic, https://github.com/rapidsai/cudf/issues/17470, and revealing explicit types of our 3rd party libraries, we should also strive make the type annotations in our private data structures explicit, namely the `ColumnBase` and its subclasses. These objects are fully owned by us and don't need to be as flexible as the pandas-like public API. Therefore, we should disallow `Any` or similar types (`ScalarLike`, `ColumnLike`) anywhere in `cudf/core/column`

xref https://mypy.readthedocs.io/en/stable/config_file.html#disallow-dynamic-typing

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.