[FEA] Handle `NaN` for floating point types in `MIN`/`MAX`/`ARGMIN`/`ARGMAX` aggregations
Open
feature request
libcudf
- Dominant language
- C++
- Stars
- 9.8k
- Forks
- 1.1k
- Avg merge
- 3d 6m
- Merged PRs (30d)
- 278
Description
Currently, the aggregations `MIN`/`MAX`/`ARGMIN`/`ARGMAX` aggregations use the default/buildit `<` comparison operator for finding the min/max row in the input column. For floating point types, we may need some other special handling, such as always considering `NaN` as the maximum value. We should be able to handle such comparisons.
In addition, since not everybody wants that behavior, we can implement such behavior as an option to the aggregation classes and the users can get what they want (either comparing `NaN` resulting UB or `NaN` is always the maximum value).
Contributor guide
Assessment
This issue has not been assessed yet.